RSS Feed/News Thread reply count is incorrect after soft-deleting large number of posts in a long enough thread

[ENXF NET]

If a user deletes a large number of individual posts in a sufficiently long thread, there is a race for xf_thread.reply_count being set to the actual correct value. This can result in the thread being "broken" where position numbers are re-used.

This is because Thread::postRemoved() acts on the existing loaded object when adjusting reply_count, and not the actual database record. Ideally the xf_thread record needs to be locked and the actual database value pushed into the...

Read more

Continue reading...