RSS Feed/News rebuildGlobalPhraseCache() unnecessarily loads all phrase records to retrieve their titles

Status
Not open for further replies.

ENXF NET

Administrator
Staff member
Administrator
Moderator
+Lifetime VIP+
S.V.I.P.S Member
S.V.I.P Member
V.I.P Member
Collaborate
Registered
Joined
Nov 13, 2018
Messages
34,050
Points
823

Reputation:

XF\Repository\LanguageRepository::rebuildGlobalPhraseCache() unnecessarily fetches all fields of global master phrases and creates Entity objects, only to extract title:

PHP:

Code:
    public function rebuildGlobalPhraseCache()
    {
        $titles = $this->finder(PhraseFinder::class)
            ->where('language_id', 0)
            ->where('global_cache', 1)
            ->fetch()
            ->pluckNamed('title');

$languages = $this->findLanguages()->fetch();

$globalPhrases...

Read more

Continue reading...
 
Status
Not open for further replies.
Top