RSS Feed/News missing _files/js causes the release builder to package the entire XenForo js directory

Status
Not open for further replies.

ENXF NET

Administrator
Staff member
Administrator
Moderator
+Lifetime VIP+
S.V.I.P.S Member
S.V.I.P Member
V.I.P Member
Collaborate
Registered
Joined
Nov 13, 2018
Messages
34,051
Points
823

Reputation:

When an add-on build.json contains:

JSON:

Code:
{
    "additional_files": [
        "js/"
    ]
}

but src/addons/ExampleAddon/_files/js does not exist, running php cmd.php xf-addon:build-release ExampleAddon

includes the installation’s entire js directory under upload/js/, including XenForo core files and other add-ons assets

Cause: In XF\Service\AddOn\ReleaseBuilderService::prepareFilesToCopy(), a missing _files path silently falls back to the XF root:

PHP:

$filePath = $rootPath ...

Read more

Continue reading...
 
Status
Not open for further replies.
Top