xF2 Add-on [J] Email Check 1.2.5

[ilona]

Anyone know? @BattleKing @ENXF NET

 

[BattleKing]

Anyone know? @BattleKing @ENXF NET

ilonaThe first one is the API key for ipqualityscore.com to check the IP.
The second one is the API key for ipqualityscore.com to check the e-mail .

So there are two email checks, one from MailCheck.ai, which checks only the domain and one from ipqualityscore.com, which checks complete email address.

 

[BattleKing]

exactly those errors get when i create new account

„Ooops something went wrong… try later”

ilonaI ve just checked the code and so far as I see, there is still an issue in there, but I cannot prove it, because not able to create an account in that page.

The following code might need to be changed in src\addons\Justin\EmailCheck\XF\Entity\User.php from:

                if($result !== null){
                    if (isset($result['valid'])) {
                        $this->error(\XF::phrase('please_enter_valid_email'), 'email');
                            return false;
                        } elseif($result['disposable'] == "true") {
                            $this->error(\XF::phrase('please_enter_valid_email'), 'email');
                            return false;
                        }
                    }

to:

                if($result !== null){
                    if (isset($result['success']) && $result['success'] == "false" ) {
                        $this->error($result['message']);
                            return false;
                        } elseif($result['disposable'] == "true") {
                            $this->error(\XF::phrase('please_enter_valid_email'), 'email');
                            return false;
                        }
                    }

Maybe someone could confirm this.

                    if (isset($result['valid'])) {

does not make any sense, because if it is set and not null then i will return an error message, but it should be the other way round. Even the above suggestion would be better.