RSS Feed/News CheckerService catch variable $e leaks into the outer scope on a non-JSON response

Status
Not open for further replies.

ENXF NET

Administrator
Staff member
Administrator
Moderator
+Lifetime VIP+
S.V.I.P.S Member
S.V.I.P Member
V.I.P Member
Collaborate
Registered
Joined
Nov 13, 2018
Messages
31,963
Points
823

Reputation:

File: src/XF/Service/Upgrade/CheckerService.php
FIle: src/XF/Service/Upgrade/Checker.php

In CheckerService::check() and Checker::check(), the inner try/catch block catches \InvalidArgumentException into a variable named $e. In PHP, catch block variables leak into the outer scope. When the response is non-JSON (e.g. a 502 Bad Gateway returning error code: 502), $responseJson is set to null and $e...

Read more

Continue reading...
 
Status
Not open for further replies.
Top