RSS Feed/News Add-on controls unnecessarily load complete template records

[ENXF NET]

Opening an add-on’s controls menu calls XF\Admin\Controller\AddOnController::actionControls(), which executes:
Code:

		$templates = $this->finder(TemplateFinder::class)
			->where('addon_id', $addOn->addon_id)
			->fetch()
			->groupBy('type');

SQL:

SELECT *
FROM xf_template
WHERE addon_id = 'OzzModz/KnowledgeBase';

All matching templates including template and template_parsed are loaded only to determine whether public/ email /admin templates exist

On large installations query can...

Read more

Continue reading...