xF2 Add-on Report Improvements by Xon 2.18.3

• Fix double-encoding of cache values, which is surprisingly expensive

• Fix N+1 queries when loading post reports.
  Do a direct node permission check rather than per-forum canView php call if the option "Reports respect view-node permission" is set
• Fix N+1 query behaviour from loading report titles

• Fix error when trying to issue a reply-ban with a warning without an expiry
• Improvements for 'non-moderators who can have reports assigned' feature
  • Run basic permission cleanup after upgrades/installs
  • Another attempt at reducing performance impact, focusing on older MySQL versions

Improve queue when discovering non-moderators who can be assigned reports, and implement caching around this list.

• Adds an index to xf_permission_entry table
• Caching requires an XenForo caching provider to be setup.
• Still appears to produce a sub-standard query plan for older versions of MySQL, but is "better" than 2.7.1

• Update a number of methods to use php 7.0 type hinting, potentially a breaking change for 3rd party add-ons extending Report Improvements
• Rename options to have more consistant naming
• Limit assigning reports to only to users who can view & update a report (rather than just view it)
• Fixes Non-moderators who can update reports;
  • Fix N+1 query behaviour
  • Improve query fetching non-moderators so it now checks that users have the view reports permission before loading the user records, and to respect the "never" permissions.
    • XenForo permission checks where still done on the list of users
  • Add "Maximum non-moderator users who can handle reports" option
    • This help prevents out-of-memory errors on viewing reports when unexpectedly loading thousands or tens of thousands of user records

• Update a number of methods to use php 7.0 type hinting, potentially a breaking change for 3rd party add-ons extending Report Improvements
• Rename options to have more consistant naming
• Limit assigning reports to only to users who can view & update a report (rather than just view it)
• Fixes Non-moderators who can update reports;
  • Fix N+1 query behaviour
  • Improve query fetching non-moderators so it now checks that users have the view reports permission before loading the user records, and to respect the "never" permissions.
    • XenForo permission checks where still done on the list of users
  • Add "Maximum non-moderator users who can handle reports" option
    • This help prevents out-of-memory errors on viewing reports when unexpectedly loading thousands or tens of thousands of user records

• Support for Report Centre Essentials v2.4.0+
• Fix N+1 query behaviour when viewing report alerts & report reactions

• Requires php 7.0+
• Now depends on Standard Library by Xon
• Supports XF2.2

Fix issuing a reply-ban from warnings did not respect the can-reply-ban permission for display. However, the permission was checked before trying to apply the reply-ban.

• Fix searching by warning point ranges when 'Search Improvements' and XFES are both installed.
• Only show warning point search in report comments if Search Improvements addon (free) is installed.
• If installed, Require Search Improvements v2.3.1.