RSS Feed/News \XF\Validator\Username::setupOptionDefaults overrides visibility

Status
Not open for further replies.

ENXF NET

Administrator
Staff member
Administrator
Moderator
+Lifetime VIP+
S.V.I.P.S Member
S.V.I.P Member
V.I.P Member
Collaborate
Registered
Joined
Nov 13, 2018
Messages
26,865
Points
823

Reputation:

\XF\Validator\Username::setupOptionDefaults is public, but \XF\Validator\Username::setupOptionDefaults is protected. There doesn't seem to be any need to override the visibility; the former could be protected.

This is a good candidate to resolve in 2.3.x, as resolving it is technically a breaking change, albeit a minor one.

Continue reading...
 
Status
Not open for further replies.
Top