RSS Feed/News [Patch Included] Style variation chooser icons don't support non-default weight

Status
Not open for further replies.

ENXF NET

Administrator
Staff member
Administrator
Moderator
+Lifetime VIP+
S.V.I.P.S Member
S.V.I.P Member
V.I.P Member
Collaborate
Registered
Joined
Nov 13, 2018
Messages
24,497
Points
823

Reputation:

js/xf/core.js
Code:

Code:
const newIcon = XF.createElementFromString(
    XF.Icon.getIcon('default', icon)
)
menuIcon.replaceWith(newIcon)

This code essentialy prevents using style variation switcher icons in a non-default weight as the runtime-generated icon HTML becomes invalid if a diffrent weight (fas, etc.) is specified.

It seems unnecessarily limiting and inconsistent with other parts of the software (like forum type icons) where it is possible to use non-default weights.

The...

Read more

Continue reading...
 
Status
Not open for further replies.
Top