RSS Feed/News Method name \XF\Http\Upload::isValid() is misleading

Status
Not open for further replies.

ENXF NET

Administrator
Staff member
Administrator
Moderator
+Lifetime VIP+
S.V.I.P.S Member
S.V.I.P Member
V.I.P Member
Collaborate
Registered
Joined
Nov 13, 2018
Messages
24,726
Points
823

Reputation:

Method name XF\Http\Upload::isValid() indicates that the method is "read only" according to \XF\Util\Php::nameIndicatedReadOnly(), but this is not necessarily the case:

If the uploaded file is an image that needs to be rotated / flipped or resized, caling isValid() internally calls transformImage() which in fact does overwrite the original upload, eg. it does modify data.

Could this be changed so calling isValid() does not modify the...

Read more

Continue reading...
 
Status
Not open for further replies.
Top