RSS Feed/News JS menu positioning fails if .menu-arrow element is missing

Status
Not open for further replies.

ENXF NET

Administrator
Staff member
Administrator
Moderator
+Lifetime VIP+
S.V.I.P.S Member
S.V.I.P Member
V.I.P Member
Collaborate
Registered
Joined
Nov 13, 2018
Messages
26,091
Points
823

Reputation:

With the refactored JS, there is one issue I've discovered; getHorizontalPosition will error out at menuArrow.style.top = '' if the menu being loaded doesn't contain an element with .menu-arrow; In XF 2.2 using jQuery it's just do a silent graceful fail on setting CSS and continue on, but without jQuery no error handling is in place for null values, so the function itself fails and it doesn't complete the positioning of the rendered menu.

Adding an element at the top of...

Read more

Continue reading...
 
Status
Not open for further replies.
Top