RSS Feed/News Improve XenForo 2.3.0 RC5 upgrade step2 performance

Status
Not open for further replies.

ENXF NET

Administrator
Staff member
Administrator
Moderator
+Lifetime VIP+
S.V.I.P.S Member
S.V.I.P Member
V.I.P Member
Collaborate
Registered
Joined
Nov 13, 2018
Messages
26,166
Points
823

Reputation:

XF\Install\Upgrade\Version2030055::step2() takes roughly 30 minutes for 1.2 million attachment_data rows. Can't this step be simplified as follows?

Diff:

Code:
--- a/src/XF/Install/Upgrade/2030055-230rc5.php
+++ b/src/XF/Install/Upgrade/2030055-230rc5.php
@@ -20,44 +20,12 @@ class Version2030055 extends AbstractUpgrade
 		});
 	}

-	public function step2(int $position, array $stepData)
+	public function step2(): void
 	{
-		if (!isset($stepData['max']))
-		{
-			$stepData['max'] =...

Read more

Continue reading...
 
Status
Not open for further replies.
Top