RSS Feed/News Extending NotifierService::notifyCreate is complicated

Status
Not open for further replies.

ENXF NET

Administrator
Staff member
Administrator
Moderator
+Lifetime VIP+
S.V.I.P.S Member
S.V.I.P Member
V.I.P Member
Collaborate
Registered
Joined
Nov 13, 2018
Messages
25,817
Points
823

Reputation:

\XF\Service\Report\NotifierService::notifyCreate is currently kinda monolithic which makes it somewhat difficult to extend.

Could this be made more modular, eg. smth. like

PHP:

Code:
protected function getCreateNotificationEmailParams(User $user): array
{
    $report = $this->report;
    $comment = $this->comment;

return [
        'receiver' => $user,
        'reporter' => $comment->User,
        'comment' => $comment,
        'report' => $report,
        'message' =>...

Read more

Continue reading...
 
Status
Not open for further replies.
Top