RSS Feed/News Discouragement "Loading delay" allows incorrect order of values

Status
Not open for further replies.

ENXF NET

Administrator
Staff member
Administrator
Moderator
+Lifetime VIP+
S.V.I.P.S Member
S.V.I.P Member
V.I.P Member
Collaborate
Registered
Joined
Nov 13, 2018
Messages
29,938
Points
823

Reputation:

You can enter values of "30" and "20" like this:

1765462561530.webp

This then throws an error ValueError: mt_rand(): Argument #2 ($max) must be greater than or equal to argument #1 ($min) src/XF/Pub/Controller/AbstractController.php:529

Should either validate the option values to enforce they're the right way round, or check which one is larger in the controller. I guess instead of:

PHP:

mt_rand($options->discourageDelay['min'], $options->discourageDelay['max'])

could do...

Read more

Continue reading...
 
Status
Not open for further replies.
Top