RSS Feed/News Conversation::assertViewableMessage: array_unique return value discarded

[ENXF NET]

\XF\Pub\Controller\Conversation::assertViewableMessage, lines 1130 through 1141:

PHP:

	protected function assertViewableMessage($messageId, array $extraWith = [])
	{
		$extraWith[] = 'Conversation';

$visitor = \XF::visitor();
		if ($visitor->user_id)
		{
			$extraWith[] = 'Conversation.Recipients|' . $visitor->user_id;
			$extraWith[] = 'Conversation.Users|' . $visitor->user_id;
		}

array_unique($extraWith);

That last line won't have any effect because the return value isn't...

Read more

Continue reading...