RSS Feed/News Approval queue will trigger unexpected rebuilds when using filters

Status
Not open for further replies.

ENXF NET

Administrator
Staff member
Administrator
Moderator
+Lifetime VIP+
S.V.I.P.S Member
S.V.I.P Member
V.I.P Member
Collaborate
Registered
Joined
Nov 13, 2018
Messages
27,908
Points
823

Reputation:

PHP:

Code:
$filters = $this->getQueueFilterInput();
$this->applyQueueFilters($unapprovedFinder, $filters);
...

if ($unapprovedItems->count() != $this->app->unapprovedCounts['total'])
{
    $approvalQueueRepo->rebuildUnapprovedCounts();
}

rebuildUnapprovedCounts will be unexpectedly called because unapprovedItems can be a limited unset of the the full list. Checking conditions on the finder isn't enough as there might be a required joins which are excluding things via a 3rd party...

Read more

Continue reading...
 
Status
Not open for further replies.
Top