RSS Feed/News AbstractJob::resume() assumes getStatusMessage non-nullable return value

Status
Not open for further replies.

ENXF NET

Administrator
Staff member
Administrator
Moderator
+Lifetime VIP+
S.V.I.P.S Member
S.V.I.P Member
V.I.P Member
Collaborate
Registered
Joined
Nov 13, 2018
Messages
28,804
Points
823

Reputation:

XF2.3 added a type hinted method JobResult::newResume() which assumes getStatusMessage() a stringable but the getStatusMessage method was never type hinted for a return type and I've seen it return null in a few of my add-ons and a few 3rd party add-ons.

I think the best fix would be for ?? '' to be added in the resume() method and a ?string return type hint added to getStatusMessage() method.

Continue reading...
 
Status
Not open for further replies.
Top